Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php-imagick: Update for PHP84 and IM7 #27588

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

php-imagick: Update for PHP84 and IM7 #27588

wants to merge 3 commits into from

Conversation

Dave-Allured
Copy link
Contributor

Description

Type(s)
Tested on

CI only.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port php-imagick.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Feb 6, 2025
@ryandesign
Copy link
Contributor

As I explained on the mailing list, I don't add subports for non-stable PHP versions.

@Dave-Allured
Copy link
Contributor Author

As I explained on the mailing list, I don't add subports for non-stable PHP versions.

Okay. This PR was intended to support Bjarne's work on PHP 8.4.3 which I assumed was stable. Converting to draft, unless someone has a different suggestion.

@Dave-Allured Dave-Allured marked this pull request as draft February 6, 2025 23:49
@ryandesign
Copy link
Contributor

My understanding was that Bjarne had prepared his changes to update php84 to stable, etc, as a stopgap until I had gotten around to updating the official ports.

@Dave-Allured
Copy link
Contributor Author

Okay. How should I dispose of this PR? I was not permitted to push it directly to Barne's branch.

@ryandesign
Copy link
Contributor

I'm happy to leave the PR here and merge it when php84 stable is in MacPorts. You can refer Bjarne to it if you'd like him to pull it into his fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryandesign ryandesign

Labels
maintainer: open Affects an openmaintainer port type: update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dave-Allured @macportsbot @ryandesign